I'm happy to mentor this. Here's a summary of what needs doing: * Add `sjs` to the list of extensions in `tools/lint/eslint.yml` * Run `./mach eslint --fix` (this may take a while). * From the output of the above command, there will be various rules that fail. Update the top-level `.eslintrc.js` to add a section into `override` to set those rules as warnings for `*.sjs` files (e.g. similar to [this example](https://searchfox.org/mozilla-central/rev/01adc17c9a41d9f7975de170acc78634bd743609/.eslintrc.js#84-98) but with `warn` rather than `off`) * Run `./mach eslint` again to ensure it now passes. * Create a commit of everything excluding the `.eslintrc.js` and `tools/lint/eslint.yml` changes. When creating that commit add `# ignore-this-changeset` onto the second or third line of the commit message. * Create a commit of just the `.eslintrc.js` and `tools/lint/eslint.yml` changes. Submit those two commits using moz-phab - they should create two revisions that are attached to this bug.
Bug 1576768 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I'm happy to mentor this. Here's a summary of what needs doing: * Create a commit that [turns off prettier](https://searchfox.org/mozilla-central/rev/01adc17c9a41d9f7975de170acc78634bd743609/toolkit/components/utils/ClientEnvironment.jsm#9,19) for the "tables" of arrays in the following files: * `toolkit/components/passwordmgr/test/authenticate.sjs` * `layout/style/test/redundant_font_download.sjs` * `dom/serviceworkers/test/fetch/deliver-gzip.sjs` * `browser/components/urlbar/tests/browser/authenticate.sjs` * `browser/components/extensions/test/browser/authenticate.sjs` * Add `sjs` to the list of extensions in `tools/lint/eslint.yml` * Run `./mach eslint --fix` (this may take a while). * From the output of the above command, there will be various rules that fail. Update the top-level `.eslintrc.js` to add a section into `override` to set those rules as warnings for `*.sjs` files (e.g. similar to [this example](https://searchfox.org/mozilla-central/rev/01adc17c9a41d9f7975de170acc78634bd743609/.eslintrc.js#84-98) but with `warn` rather than `off`) * Run `./mach eslint` again to ensure it now passes. * Create a commit of everything excluding the `.eslintrc.js` and `tools/lint/eslint.yml` changes. When creating that commit add `# ignore-this-changeset` onto the second or third line of the commit message. * Create a commit of just the `.eslintrc.js` and `tools/lint/eslint.yml` changes. Submit those two commits using moz-phab - they should create two revisions that are attached to this bug.